Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preferences): Added support for iOS suites #2153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

micbis
Copy link

@micbis micbis commented Jul 17, 2024

This is needed i.e. to share data with a notification service extension.

Replacing the former PR #1966

@JohanBeumer
Copy link

JohanBeumer commented Jul 19, 2024

@micbis I was trying to use your changes, but ran into a problem. Maybe a merge did not go well?
When I comment the lines below in PreferencesPlugin.swift it works for me.

I am not a reviewer, just an enthusiastic user who loves to see your changes merged.

        if group == nil, let suite = suite {
            configuration = PreferencesConfiguration(for: suite)
        } else {
            if let group = group, let suite = suite {
                if group == "NativeStorage" {
                    configuration = PreferencesConfiguration(for: suite, for: .cordovaNativeStorage)
                } else {
                    configuration = PreferencesConfiguration(for: suite, for: .named(group))
                }
            } else {
                // configuration = PreferencesConfiguration(for: .named(group))
                configuration = PreferencesConfiguration()
            }
        } // else {
//            configuration = PreferencesConfiguration()
//        }

@micbis
Copy link
Author

micbis commented Jul 22, 2024

@JohanBeumer Thanks, looks like. Will fix that asap.

@micbis micbis force-pushed the feature/ios-suites branch from 9add975 to 5922fe0 Compare July 23, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants