Feat(Model Manager): Add improved download manager with pause/resume partial download.#8864
Open
DustyShoe wants to merge 14 commits intoinvoke-ai:mainfrom
Open
Feat(Model Manager): Add improved download manager with pause/resume partial download.#8864DustyShoe wants to merge 14 commits intoinvoke-ai:mainfrom
DustyShoe wants to merge 14 commits intoinvoke-ai:mainfrom
Conversation
Collaborator
|
@DustyShoe Does this handle the case where the user pauses and either:
|
Collaborator
Author
|
@JPPhoto Ofc. you had to find worst case scenario...
|
Collaborator
|
@DustyShoe We can't predict what users or their systems will do, so coding defensively and being resilient (to a point) is always good. |
Collaborator
Author
|
@JPPhoto Have to admit, that was a good point actually. Went back and added explicit toast message if temp file was removed and user tries to restart download. Also there was a bug in status bar updating. It did never reset to 0 in that case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds few cool things:
Parts of this code were written with assistance, so I’d appreciate any fixes or improvements.
QA Instructions
It might be better to run this with debug logging enabled.
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)