Skip to content

Prompt Attention Fixes#8860

Open
joshistoast wants to merge 5 commits intoinvoke-ai:mainfrom
joshistoast:fix/prompt-attn-fixes
Open

Prompt Attention Fixes#8860
joshistoast wants to merge 5 commits intoinvoke-ai:mainfrom
joshistoast:fix/prompt-attn-fixes

Conversation

@joshistoast
Copy link
Contributor

@joshistoast joshistoast commented Feb 7, 2026

Summary

Addresses issues, oversights and edge cases surrounding the prompt attention hotkey feature.

Fixes and Improvements:

  • Add more supported punctuations so they don't get parsed away;
  • Fixed floating point corruption, numeric weighting is now more predictable;
  • Added attention style preference to settings modal;
  • Added prompt functions to AST;
  • Now respects prompt functions like .blend(), .and() and .or();
  • (more fixes will be added here as they come)

Related Issues / Discussions

Discussed in #8736

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • ❗Changes to a redux slice have a corresponding migration
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Feb 7, 2026
@DustyShoe
Copy link
Collaborator

Based on my quick testing, the outermost parentheses wrapping the entire chunked prompt are still being stripped. The same issue occurs with .and()

Example:

("high detail, (cinematic lighting)1.25, soft volumetric light, (sharp focus)+, professional photography",
 "a young woman with balanced natural proportions, medium length brown hair, neutral expression, casual modern clothing",
 "subtle rim light, shallow depth of field, natural skin texture, clean background")
.and()

Becomes

"high detail, (cinematic lighting)1.25, soft volumetric light, (sharp focus)+, professional photography+",
 "a young woman with balanced natural proportions, medium length brown hair, neutral expression, casual modern clothing",
 "subtle rim light, shallow depth of field, natural skin texture, clean background"
.and

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend PRs that change frontend files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants