Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: workflow builder #7608

Merged
merged 126 commits into from
Feb 14, 2025
Merged

feat: workflow builder #7608

merged 126 commits into from
Feb 14, 2025

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Jan 31, 2025 •
edited
Loading

Summary

  • Add drag-and-drop workflow builder UI, replacing the simple list of linear view fields. Old linear view is migrated.
  • Refactor of a crapload of workflows components.
  • Fix issues with auto-node selection when creating edges.
  • Improved performance across workflow editor.
  • Upgrade reactflow to latest. I was already fixing/changing a ton of stuff so it was a good time to lump this in.
  • Update @invoke-ai/ui-library to latest. Needed for some of the UI stuff in workflow builder.
  • When loading a workflow, nodes are auto-updated.

Related Issues / Discussions

TBD

QA Instructions

TBD

Merge Plan

TBD

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added frontend-deps PRs that change frontend dependencies frontend PRs that change frontend files labels Jan 31, 2025
@psychedelicious psychedelicious mentioned this pull request Jan 31, 2025
Closed
1 task
@psychedelicious psychedelicious force-pushed the psyche/feat/workflow-builder branch 4 times, most recently from 7cf5c97 to 5b93a3f Compare February 11, 2025 08:17
@psychedelicious psychedelicious marked this pull request as ready for review February 11, 2025 12:11
@hipsterusername
Copy link
Member

hipsterusername commented Feb 11, 2025 •
edited
Loading

Having issues getting the workflow section to load up - May need some pairing to see if it's me or the branch

Edit: PEBKAC

hipsterusername
hipsterusername approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@hipsterusername hipsterusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending metadata

@psychedelicious psychedelicious force-pushed the psyche/feat/workflow-builder branch from 4cd1a07 to 749b15a Compare February 12, 2025 05:35
@psychedelicious psychedelicious mentioned this pull request Feb 14, 2025
Merged
4 tasks
@psychedelicious psychedelicious force-pushed the psyche/feat/workflow-builder branch from 749b15a to 02c75eb Compare February 14, 2025 03:23
@psychedelicious
feat(ui): add notes state to fields
9bc9cc9
@psychedelicious
feat(ui): add notes popover to field title bar
9604229
@psychedelicious
feat(ui): show notes icon on editor linear view
620717b
@psychedelicious
feat(ui): show notes icon on user-linear view, replacing info icon
f825b3a
@psychedelicious
feat(ui): clean up user-linear view styling
6cadf9b
@psychedelicious
feat(ui): add ViewContext so components can know where they are being…
6a26d44 
… rendered (user-linear view, editor-linear view, or editor-nodes view)
@psychedelicious
perf(ui): use data attribute for input field wrapper styles
c540b3f
@psychedelicious
refactor(ui): workflows component structure (WIP)
c1e1bdd 
- Simplify and de-insane-ify component structure, hooks, selectors, etc.
- Some perf improvements by using data attributes for styling instead of dynamic CSS-in-JS.
- Add field notes and start of linear view config, got blocked when I ran into deeper layout issues that made it very difficult to handle field configs. So those are WIP in this commit.
@psychedelicious
refactor(ui): workflows left panel internal components structure
3448634
@psychedelicious
fix(ui): remove accidental change to zFieldInput schema
6ed3b10
@psychedelicious
refactor(ui): continued reorg of components & hooks
b3acecd
@psychedelicious
refactor(ui): continued reorg of components & hooks
f49abc4
@psychedelicious
tidy(ui): extract util in dnd
75fb2a3
@psychedelicious
tidy(ui): useNodeFieldDnd
7ae5cc5
@psychedelicious
feat(ui): demote dnd logs to trace
f259d8e
@psychedelicious
refactor(ui): remove confusing containerId from various builder act…
1fab4e7 
…ions
@psychedelicious
feat(ui): default form field settings
e379857
@psychedelicious
tweak(ui): layout of workflow builder field settings
1b07ef9
@psychedelicious
feat(ui): better placeholders for text/heading
a1ed784
@psychedelicious
feat(ui): add initial values for builder fields
ea0b327
@psychedelicious
feat(ui): remove the showLabel flag for node fields
3aaffa4
@psychedelicious
tidy(ui): builder dnd monitor logic rearrange
cd3d152
@psychedelicious
fix(ui): ignore dropping on self
045747a
@psychedelicious
feat(ui): remove node field reset button from edit mode header
e66490f
@psychedelicious
tweak(ui): styling for edit mode
54532a1
@psychedelicious
feat(ui): remove element id from edit mode header
5d2ea42
@psychedelicious
feat(ui): text and heading element default content is empty string
15075df
@psychedelicious
feat(ui): remove separate flag for form vs workflow edit mode
5c7269c
@psychedelicious
feat(ui): consolidate row/column dnd draggables into container
26fbb40
@psychedelicious
tweak(ui): builder padding
8e6290b
@psychedelicious
tidy(ui): remove nonfunctional conditionals
a6257eb
@psychedelicious
fix(ui): remove images from node image collections when deleted
dc3e5f1
@psychedelicious
feat(ui): add delete button to missing image placeholder for image co…
ff92654 
…llection fields
@psychedelicious
fix(ui): force refetch when checking image access to ensure stale RTK…
38162ad 
… query cache isn't use
@psychedelicious
feat(ui): check image access for image collections when loading workf…
58106c5 
…lows
@psychedelicious
feat(ui): add warning about alpha status of builder
da4f43f
@psychedelicious
tweak(ui): form element edit mode styling
b23efa9
@psychedelicious
feat(ui): give vertical dividers a min height
9ae978a
@psychedelicious
chore(ui): knip
daa41a5
@psychedelicious psychedelicious force-pushed the psyche/feat/workflow-builder branch from 02c75eb to daa41a5 Compare February 14, 2025 03:27
@psychedelicious psychedelicious merged commit f3dfb1b into main Feb 14, 2025
15 checks passed
@psychedelicious psychedelicious deleted the psyche/feat/workflow-builder branch February 14, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername