Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update UI to display VAE override for model as dropdown of installed options #5815

Closed
wants to merge 2 commits into from
Closed

update UI to display VAE override for model as dropdown of installed options #5815

wants to merge 2 commits into from
+75 −35

Conversation

maryhipp
Copy link
Collaborator

@maryhipp maryhipp commented Feb 27, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Have you updated all relevant documentation?

  • Yes
  • No

Description

Updates the VAE dropdown on the model edit screen to display options as a list of installed models, instead of a text input for the path.

Concerns:

  • this will have weird behavior for models that already have vae override set to a path for a model that is not "installed"
  • will require users to install any VAE that they want to use as an override

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Merge Plan

Added/updated tests?

  • Yes
  • No : please replace this line with details on why tests
    have not been included

[optional] Are there any post deployment tasks we need to perform?

@maryhipp maryhipp changed the base branch from main to next February 27, 2024 15:44
@github-actions github-actions bot added documentation Improvements or additions to documentation api python PRs that change python files Root invocations PRs that change invocations backend PRs that change backend files services PRs that change app services frontend-deps PRs that change frontend dependencies frontend PRs that change frontend files CICD labels Feb 27, 2024
@maryhipp maryhipp closed this Feb 28, 2024
@maryhipp maryhipp deleted the maryhipp/model-edit-vae-list branch March 4, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@psychedelicious psychedelicious Awaiting requested review from psychedelicious psychedelicious is a code owner

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@lstein lstein Awaiting requested review from lstein

@ebr ebr Awaiting requested review from ebr

@GreggHelt2 GreggHelt2 Awaiting requested review from GreggHelt2

@brandonrising brandonrising Awaiting requested review from brandonrising

@RyanJDick RyanJDick Awaiting requested review from RyanJDick

Assignees
No one assigned
Labels
api backend PRs that change backend files CICD documentation Improvements or additions to documentation frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies invocations PRs that change invocations python PRs that change python files Root services PRs that change app services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maryhipp @hipsterusername