[Cleanup] Implementing Warning Banner For Clients | E-Invoicing #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@turbo124 You also mentioned in the ticket about ensuring that the form accepts helper text. If you mean that we need to have helper text on |
|
translation client_address_required logic address1,city,postal_code,country_id != '' |
@turbo124 The translation keyword has been set, and I can confirm that the logic is exactly as you mentioned - if any of those props is not populated, the banner will be displayed. Of course, if the e-invoicing has been enabled. Let me know your thoughts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@beganovich @turbo124 The PR includes the implementation of warning banner for clients under certain conditions. Screenshot:
Note: I used plain text to display a banner with a message that makes sense, but please let me know which translation keyword you would prefer here.Let me know your thoughts.