Conversation
Lyokone
commented
Jan 23, 2026
Comment on lines
+427
to
+430
| // For Dart, include the function name in the path so the server can route | ||
| // For other runtimes, use / as they use FUNCTION_TARGET env var | ||
| const isDart = runtime?.startsWith("dart"); | ||
| const path = isDart ? `/${trigger.entryPoint}` : `/`; |
Lyokone
commented
Jan 23, 2026
| private staticBackends: EmulatableBackend[] = []; | ||
| private dynamicBackends: EmulatableBackend[] = []; | ||
| private watchers: chokidar.FSWatcher[] = []; | ||
| private buildRunnerProcesses: Map<string, ChildProcess> = new Map(); |
Author
There was a problem hiding this comment.
Same here, feels like we are polluting something generic
Ehesp
reviewed
Jan 23, 2026
|
|
||
| // For Dart, include the function name in the path so the server can route | ||
| // For other runtimes, use / as they use FUNCTION_TARGET env var | ||
| const isDart = runtime?.startsWith("dart"); |
Member
There was a problem hiding this comment.
Feels like this should be easier to check? E.g. for each runtime add a runtime type enum/const, so we can do:
runtime.type === RUNTIMES.DART
Or something... maybe out of scope of the PR.
| dependencies: | ||
| firebase_functions: | ||
| path: ../ | ||
| shelf: |
Member
There was a problem hiding this comment.
TODO: Remove once we wrap shelf types
Lyokone
commented
Jan 23, 2026
| /.+?[\\\/]venv[\\\/].+?/, // Ignore site-packages in venv | ||
| ...(backend.ignore?.map((i) => `**/${i}`) ?? []), | ||
| ], | ||
| ignored: isDart |
Author
There was a problem hiding this comment.
Same here, wondering if it's not polluting too much, maybe we should try to integrate with the
async build(): Promise<void> {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands