Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase coverage #8897

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Conversation

matmair
Copy link
Member

@matmair matmair commented Jan 14, 2025

Increase coverage of the backend and fix various small things discovered during test writing; Preparation for #8874

@matmair matmair added the CI CI / unit testing ecosystem label Jan 14, 2025
@matmair matmair added this to the 1.0.0 milestone Jan 14, 2025
@matmair matmair self-assigned this Jan 14, 2025
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 8b59561
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/678ed194ab82d60008180b31

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 97.82609% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.39%. Comparing base (f602c43) to head (8b59561).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rc/backend/InvenTree/report/templatetags/report.py 88.00% 3 Missing ⚠️
src/backend/InvenTree/report/tests.py 71.42% 2 Missing ⚠️
src/backend/InvenTree/report/test_tags.py 99.54% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8897      +/-   ##
==========================================
+ Coverage   85.17%   85.39%   +0.22%     
==========================================
  Files        1175     1179       +4     
  Lines       51808    51881      +73     
  Branches     2106     2099       -7     
==========================================
+ Hits        44127    44304     +177     
+ Misses       7147     7042     -105     
- Partials      534      535       +1     
Flag Coverage Δ
backend 87.21% <97.82%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matmair matmair changed the title Feat: increase coverage feat: increase coverage Jan 15, 2025
@matmair matmair marked this pull request as ready for review January 16, 2025 00:42
@SchrodingersGat
Copy link
Member

@matmair please address conflicts here and then I'm happy to merge :)

@matmair
Copy link
Member Author

matmair commented Jan 19, 2025

@SchrodingersGat done

@matmair matmair mentioned this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants