Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions: Add Community Creator Role for can_create #1231

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented Oct 16, 2024

❤️ Thank you for your contribution!

Description

  • The can_create permission will now have the option to check if RDM_COMMUNITY_REQUIRED_TO_PUBLISH is set to True, requiring the user to have the community manager role to create new communities.
  • The community creator role name can be overridden from the user instance.
  • Closes Require a community when uploading product-rdm#183
  • Update communities settings so it can always be closed if the config is True
    image

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Samk13 and others added 2 commits October 19, 2024 17:59
* The `can_create` function will now check if `RDM_COMMUNITY_REQUIRED_TO_PUBLISH` is set to True, requiring the user to have the community manager role to create new communities.
* The community creator role can be overridden from the user side.
* Closes inveniosoftware/product-rdm#183
@Samk13 Samk13 force-pushed the feat-community-creator branch 2 times, most recently from 4ace4c6 to fca2de3 Compare October 19, 2024 20:35
* When RDM_COMMUNITY_REQUIRED_TO_PUBLISH is set to True we limit the options available for review policies to closed.
@Samk13 Samk13 force-pushed the feat-community-creator branch from fca2de3 to 8c0e30f Compare October 19, 2024 20:43
@ntarocco
Copy link
Contributor

I think that this is not needed. You can override the community service permissions in your instance, as we did it in our instance at CERN, see example here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require a community when uploading
2 participants