chore: add proper labels #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
egabancho
commented
Dec 5, 2024
egabancho
commented
- closes Default and unique label sets that comply with the k8s specifications #114
lindhe
reviewed
Dec 6, 2024
Comment on lines
46
to
51
| {{- define "invenio.selectorLabels" -}} | ||
| app.kubernetes.io/name: {{ include "invenio.name" . }} | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| {{- end }} |
There was a problem hiding this comment.
I think it's valid to define a template after it's used (it's used on line 38 and defined here at line 46). But I think it reads better for people if we define it first. Also it's missing a blank newline.
There was a problem hiding this comment.
I just ran helm create invenio on a different folder and copy over the content from _helpers.tpl
lindhe
reviewed
Dec 6, 2024
lindhe
reviewed
Dec 6, 2024
| We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). | ||
| If release name contains chart name it will be used as a full name. | ||
| */}} | ||
| {{- define "invenio.fullname" -}} |
There was a problem hiding this comment.
Seems like you define invenio.fullname but never use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.