Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: 204 error shouldn't have content #85

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

tmorrell
Copy link
Contributor

❤️ Thank you for your contribution!

Description

Fix 204 error in tests so CI works

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@tmorrell tmorrell requested a review from utnapischtim January 30, 2024 00:27
@tmorrell
Copy link
Contributor Author

tmorrell commented Feb 5, 2024

@edager do you have a second to review this PR? It will fix the CI so we can start working on 4.5

@edager
Copy link
Contributor

edager commented Feb 9, 2024

Hi @tmorrell,

Sure, I can have a look if you want, however I'm still not completely familiar with how this implementation of the connection to datacite works, just so you're warned.

@tmorrell
Copy link
Contributor Author

tmorrell commented Feb 9, 2024

It's a two line change to make the tests work again. I just need someone else to review before I merge. Thanks!

@edager
Copy link
Contributor

edager commented Feb 12, 2024

Looks completely reasonable to me that there shouldn't be any content in the body when testing a 204 error. Can you add my as reviewer?

@tmorrell tmorrell merged commit b782949 into inveniosoftware:master Feb 12, 2024
3 checks passed
@tmorrell
Copy link
Contributor Author

GitHub didn't allow me to add you as a reviewer...so I'll take your comment as a positive review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants