fix: messages deepCopy
mutates src
arguments
#1947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This has not been thoroughly tested but should demonstrate the issue with
deepCopy
Currently during
deepCopy
if a key is unset, it will be assigned to the value of thesrc[key]
, this is an issue for objects as they will be assigned by reference, meaning following calls todeepCopy
will assign properties on these objects.So far a simple solution seems to be to set the property value to an empty object/array, this ensures both
src[key]
anddes[key]
are objects meaningdeepCopy
will merge these as such instead of direct assignment.I've had this saved in a git stash for some time so it has been a while since debugging this issue, I'm opening this PR so I won't forget about it again 😅
nuxt-modules/i18n#3089
nuxt-modules/i18n#2803