Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-duplicate-keys-in-locale rule and change no-missing-keys rule to not report if there is one matching key in each locale #112

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

ota-meshi
Copy link
Member

This PR makes the following two changes.

  • Adds no-duplicate-keys-in-locale rule that reports duplicate localization keys within the same locale.
  • Changes no-missing-keys rule to not report if there is one matching key in each locale.

close #104

…to not report if there is one matching key in each locale.
@ota-meshi ota-meshi added the Type: Feature Includes new features label Aug 12, 2020
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ota-meshi ota-meshi merged commit 7614169 into master Aug 12, 2020
@ota-meshi ota-meshi deleted the no-duplicate-keys-in-locale branch August 12, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Includes new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Proposal: no-duplicate-keys-in-locale
2 participants