-
-
Notifications
You must be signed in to change notification settings - Fork 39
-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
`no-duplicate-message-in-locale' rule #8
Comments
Hi @kazupon! I think this rule is probably better off not determining if it's a duplicate message for each locale. For example, English and Japanese messages about dates may use the same message but have different meanings. e.g. en:
month: Month
short_sun: S # duplicate?
short_mon: M
short_tue: T # duplicate?
short_wed: W
short_thu: T # duplicate?
short_fri: F
short_sat: S # duplicate?
ja:
month: 月 # duplicate?
short_sun: 日
short_mon: 月 # duplicate?
short_tue: 火
short_wed: 水
short_thu: 木
short_fri: 金
short_sat: 土 In my opinion, it may be possible to reduce false positives by reporting only if there are duplicates in all locales: en:
key1: dupe_message1 # Will report it
key2: dupe_message1 # Will report it
key3: dupe_message2 # Do not report it because it is not duplicated in "ja"
key4: dupe_message2 # Do not report it because it is not duplicated in "ja"
ja:
key1: 重複_メッセージ1 # Will report it
key2: 重複_メッセージ1 # Will report it
key3: メッセージ3
key4: メッセージ4 Even then, it may still incorrectly report the same string message with different meanings. |
Indeed. 🤔 In about this rule, let's keep the pending. |
No description provided.
The text was updated successfully, but these errors were encountered: