-
-
Notifications
You must be signed in to change notification settings - Fork 39
-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule Proposal: no-duplicate-keys-in-locale #104
Labels
Type: Feature
Includes new features
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please describe what the rule should do:
This rule reports duplicate keys within the same locale.
What category of rule is this? (place an "X" next to just one item)
[ ] Enforces code style (layout)
[X] Warns about a potential error (problem)
[ ] Suggests an alternate way of doing something (suggestion)
[ ] Other (please specify:)
Provide 2-3 code examples that this rule will warn about:
Additional context
I found in #79 that some users have multiple resources for the same locale.
I thought that if you split into multiple files, you will not be able to check for duplicate keys or missing keys, but I realized that this plugin mechanism can implement rules to check for duplicate keys and missing keys.
If we add this rule, we need to change the
no-missing-keys
rule to not report if you have at least one hit in the same locale.I also considered whether a rule was needed to report keys that were existing in one locale and missing in another.
In my opinion, this rule is not needed as the reporting of the
no-missing-keys
rule meets this.The text was updated successfully, but these errors were encountered: