Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add system settings #634

Merged
merged 6 commits into from
Nov 18, 2024
Merged

add system settings #634

merged 6 commits into from
Nov 18, 2024

Conversation

isc-etamarch
Copy link
Collaborator

Fixes #535

@isc-tleavitt Let me know if settings should be added / removed from the ones saved

@isc-etamarch isc-etamarch linked an issue Nov 8, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.84%. Comparing base (4c5dfee) to head (bbb13b3).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   41.84%   41.84%           
=======================================
  Files          22       22           
  Lines        3016     3016           
=======================================
  Hits         1262     1262           
  Misses       1754     1754           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: from a SemVer perspective, "Added" means we're going from a patch (bugfix) release to a minor release, so the changelog and module.xml should update to 2.8.0 accordingly.

csp/gitprojectsettings.csp Outdated Show resolved Hide resolved
cls/SourceControl/Git/Settings.cls Outdated Show resolved Hide resolved
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit, let's put Added before Fixed in the changelog, should have said that before.

I'm going to hold this in Approved until we decide if we're going to do a bugfix release prior to releasing Production Decomposition.

@isc-tleavitt isc-tleavitt merged commit 51288e8 into main Nov 18, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the issue-535 branch November 18, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support system-wide default settings
3 participants