-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add system settings #634
add system settings #634
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
=======================================
Coverage 41.84% 41.84%
=======================================
Files 22 22
Lines 3016 3016
=======================================
Hits 1262 1262
Misses 1754 1754 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: from a SemVer perspective, "Added" means we're going from a patch (bugfix) release to a minor release, so the changelog and module.xml should update to 2.8.0 accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nit, let's put Added before Fixed in the changelog, should have said that before.
I'm going to hold this in Approved until we decide if we're going to do a bugfix release prior to releasing Production Decomposition.
Fixes #535
@isc-tleavitt Let me know if settings should be added / removed from the ones saved