Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination for Show Table Records #54

Merged

Conversation

gjsjohnmurray
Copy link
Collaborator

When using the Show Table Records button in connection explorer, make pagination work.

@gjsjohnmurray
Copy link
Collaborator Author

CI failure might resolve if/when @daimor's CI changes in #53 get merged to master and then merged to this branch.

@gjsjohnmurray gjsjohnmurray mentioned this pull request May 1, 2024
Copy link
Member

@isc-rsingh isc-rsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why SELECT TOP ALL is needed? I trust you but I'm curious why it's needed.

@gjsjohnmurray
Copy link
Collaborator Author

Can you explain why SELECT TOP ALL is needed? I trust you but I'm curious why it's needed.

I think I got that tip from https://community.intersystems.com/post/there-any-way-paginate-sql-query-cach%C3%A9#comment-43156

@gjsjohnmurray gjsjohnmurray merged commit 4841a70 into intersystems-community:master Aug 30, 2024
3 checks passed
@gjsjohnmurray gjsjohnmurray deleted the crimson-marlin branch August 30, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants