Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogicValue radixString uses underscore separators by default #535

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

desmonddak
Copy link
Contributor

Description & Motivation

Added an option to LogicValue.toRadixString and .ofRadixString to use '_' as a default separator, but allow
for the user to specify a different separator.

Related Issue(s)

#534

Testing

Converted tests to use _ as separator after testing with sepChar argument.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Yes. Previously output radixStrings will not parse by default as they will have spaces.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Documentation in the class code is now up to date with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants