Fixed lossy #172
Merged
Fixed lossy #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
reviewed
Feb 7, 2025
|
I wonder if I should add a wrapper component called 'FloatToFixedPoint' which takes both a FloatingPoint and a FixedPoint, extending this Module and passing in the m, n from the FixedPoint. For the lossless case, we still need this class. This idea should be covered in an FP refactoring for components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
We need converters from float to fixed that are lossy (e.g. are constrained by fixed parameters m, n. This PR creates this.
Related Issue(s)
Testing
Exhaustive testing at narrow widths, e.g., BF16->18.16.
Backwards-compatibility
No.
Documentation
Yes. Markdown updated to document the addition of optional inputs m,n and the checkOverflow flag.