Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds conditions to keep QDQ #565

Open
wants to merge 3 commits into
base: ovep-develop
Choose a base branch
from

Conversation

rayngun
Copy link

@rayngun rayngun commented Feb 6, 2025

The conditions are based on

  • keep uint8/int8 QDQs after Conv (except Conv -> QDQ -> Bias Add/Div/Mul)
  • keep DQ if used for initializer
  • QDQ pair before Conv should be stripped if the QDQ pair is uint16/int16

@rayngun rayngun marked this pull request as ready for review February 6, 2025 01:01
@sfatimar
Copy link

sfatimar commented Feb 7, 2025

@saurabhkale17 please review

@sfatimar
Copy link

@rayngun @saurabhkale17 PR is unblocked Please rebase, review and ready to merge

@saurabhkale17
Copy link

@rayngun Can you please rebase the branch
27 file changes.

jatinwadhwa921 and others added 2 commits February 11, 2025 17:03
* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <[email protected]>
The conditions are based on
 - keep uint8/int8 QDQs after Conv (except Conv -> QDQ -> Bias Add/Div/Mul)
 - keep DQ if used for initializer
 - QDQ pair before Conv should be stripped if the QDQ pair is uint16/int16
@sfatimar
Copy link

@jatinwadhwa921 Internal CI is failing, is the branch issue not resolved
@saurabhkale17 please review.

@jatinwadhwa921
Copy link

@rayngun @sfatimar the internal ci will keep failing as it unable to access the branch of @rayngun as it is coming from a forked repo due to which our internal-ci shows authorization issues. @rayngun can make a branch in intel-fork repo and raise a pr from their which will trigger the internal-ci

@sfatimar
Copy link

Is there any way such use cases can be handled ? As I expect many developers to raise from their private repo?

@jatinwadhwa921
Copy link

Is there any way such use cases can be handled ? As I expect many developers to raise from their private repo?

I have to see on how we can authorize. i will have to make changes in my internal ci logic, will try to find a solution for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants