Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Add new descriptors based on sycl_ext_intel_device_info extension #17492

Merged
merged 7 commits into from
Mar 20, 2025
Merged

[SYCL] Add new descriptors based on sycl_ext_intel_device_info extension #17492

merged 7 commits into from
Mar 20, 2025
+789 −38

Conversation

againull
Copy link
Contributor

@againull againull commented Mar 17, 2025 •
edited
Loading

Add device descriptors based on the extension update: #17386

@againull againull requested review from a team as code owners March 17, 2025 17:04
@againull againull requested review from Seanst98 and slawekptak March 17, 2025 17:04
@againull againull changed the title [SYCL] Add new descriptors to sycl_ext_intel_device_info extension [SYCL] Add new descriptors based on sycl_ext_intel_device_info extension Mar 17, 2025
@againull
Copy link
Contributor Author

againull commented Mar 19, 2025 •
edited
Loading

@intel/dpcpp-tools-reviewers @intel/unified-runtime-reviewers @Seanst98 @slawekptak Could you please take a look.

aarongreig
aarongreig approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@aarongreig aarongreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UR changes look good. We should get a review from @nrspruit or @pbalcer on the l0 adapter change

Seanst98
Seanst98 approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@Seanst98 Seanst98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA/HIP changes LGTM.

AlexeySachkov
AlexeySachkov approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device config file changes LGTM

slawekptak
slawekptak reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@slawekptak slawekptak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SYCL changes LGTM.

@againull againull requested a review from slawekptak March 20, 2025 15:36
@againull againull requested a review from nrspruit March 20, 2025 20:10
@againull againull merged commit 33e7f73 into intel:sycl Mar 20, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvdijk hvdijk

@AlexeySachkov AlexeySachkov

@nrspruit nrspruit

@Seanst98 Seanst98

@slawekptak slawekptak

@aarongreig aarongreig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@againull @hvdijk @AlexeySachkov @nrspruit @Seanst98 @slawekptak @aarongreig