Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UR] Check null pointer before handle in validation layer #17474

Merged
merged 4 commits into from
Mar 17, 2025

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Mar 14, 2025

  • Adjust mako template for ur_valddi.cpp so that pointers are null-checked before handles
  • Fixes issue with handles inside a pointer to a struct where the pointer would be dereferenced to check for a null handle before the pointer itself was null checked.
  • Updates some tests which passed additional null pointer args when checking for null handle errors, which would fail since the null pointer errors take priority now.

Issue was found during coverity scan.

- Adjust mako template for ur_valddi.cpp so that pointers are null-checked before handles
- Fixes issue with handles inside a pointer to a struct where the pointer would be dereferenced to check for a null handle before the pointer itself was null checked.
@Bensuo Bensuo requested a review from a team as a code owner March 14, 2025 14:00
- Not passing a selected binary pointer caused that pointer to be checked before the handle
Bensuo added 2 commits March 14, 2025 17:14
- Fix more tests that passed null pointers when trying to check for null handle errors
@Bensuo
Copy link
Contributor Author

Bensuo commented Mar 17, 2025

@intel/llvm-gatekeepers This should be good to merge now, thanks!

@kbenzie kbenzie merged commit 7650d83 into intel:sycl Mar 17, 2025
42 of 43 checks passed
@Bensuo Bensuo deleted the ben/coverity-validation-order branch March 17, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants