[SYCL][Bindless][E2E] Add 1D host USM tests #17374
Conversation
Adds 1D Host USM backed image tests. This patch also fixes device aspect queries for 1D & 2D USM backed image sampling support.
sycl/test-e2e/bindless_images/sampled_fetch/fetch_1D_USM_host.cpp
Outdated
Show resolved
Hide resolved
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Non-blocking question: should this commit have the |
przemektmalon
changed the title
Should probably have [SYCL], added. Not sure if it's necessary to force-push to update the original commit message though, or if the GitHub title change is enough. |
GitHub title change is enough. bindless_images/sampled_fetch/fetch_1D_USM_host.cpp is failing. Will review after it is fixed. |
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@KseniyaTikhomirova the CI failure has now been fixed. |
|
Friendly ping @intel/llvm-reviewers-runtime |
| // UNSUPPORTED: hip | ||
| // UNSUPPORTED-INTENDED: Host USM backed image support is not yet enabled in UR | ||
| // adapter. Also, when provionally enabled, the test crashes upon image | ||
| // creation, whereas Device USM backed images do not crash. This issue is |
There was a problem hiding this comment.
What do you mean under "this issue is undetermined"? Do you suspect an issue in HIP backend? HIP adapter? Should we probably report it?
There was a problem hiding this comment.
The source of the problem is not yet known, but we are tracking the issue internally.
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers this is ready to merge |
Adds 1D Host USM backed image tests.
This patch also fixes device aspect queries for 1D & 2D USM backed image sampling support.