[SYCL][test-e2e] <latch> is a C++20 header #16468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<latch> requires c++20 support in the standard library which is not a guarantee on all implementations. Fake latch support for the empty_command test with a simple atomic int wrapper. It's rough but doesn't need to support all generality of the standard version
omarahmed1111
approved these changes
Dec 24, 2024
ldrumm
changed the title
|
How did you find it and why do we need such old gcc in CI? I understand that we can't use C++20 in the headers, but I'd imagine that for the E2E it should be relatively fine. Is that STL-only issue on the toolchain you care (i.e., is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires c++20 support in the standard library which is not a guarantee on all implementations. Fake latch support for the empty_command test with a simple atomic int wrapper. It's rough but doesn't need to support all generality of the standard version