Skip to content

Commit

Permalink
[SYCL] Add XFAIL trackers for several E2E tests marked with XFAIL (#1…
Browse files Browse the repository at this point in the history
…6287)

This PR is the first in a series of PR's to add XFAIL tracker issues for
several tests marked as XFAIL on certain platforms.
For XFAIL's on a hip_nvidia platform, we simply remove the XFAIL
entirely as we do not test the configuration anymore.
Also, this PR deleted 6 tests failing everywhere because of an issue
that will not be fixed.
  • Loading branch information
lbushi25 authored Dec 6, 2024
1 parent c51ca91 commit b0000e0
Show file tree
Hide file tree
Showing 37 changed files with 10 additions and 603 deletions.
1 change: 1 addition & 0 deletions sycl/test-e2e/Basic/buffer/reinterpret.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// RUN: %{run} %t.out
//
// XFAIL: level_zero&&gpu
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14430

//==---------- reinterpret.cpp --- SYCL buffer reinterpret basic test ------==//
//
Expand Down
3 changes: 1 addition & 2 deletions sycl/test-e2e/Basic/queue/queue.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
//
// XFAIL: hip_nvidia

//==--------------- queue.cpp - SYCL queue test ----------------------------==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/Basic/queue/release.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// RUN: %{build} -o %t.out
// RUN: env SYCL_UR_TRACE=2 %{run} %t.out | FileCheck %s %if !windows %{--check-prefixes=CHECK-RELEASE%}
//
// XFAIL: hip_nvidia

#include <sycl/detail/core.hpp>
int main() {
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/Basic/span.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
//
// Fails to release USM pointer on HIP for NVIDIA
// XFAIL: hip_nvidia
// REQUIRES: aspect-usm_shared_allocations
#include <numeric>

Expand Down
3 changes: 1 addition & 2 deletions sycl/test-e2e/Basic/stream/auto_flush.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out %if !gpu || linux %{ | FileCheck %s %}
//
// XFAIL: hip_nvidia

//==-------------- copy.cpp - SYCL stream obect auto flushing test ---------==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
Expand Down
5 changes: 1 addition & 4 deletions sycl/test-e2e/DeprecatedFeatures/queue_old_interop.cpp
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
// RUN: %{build} -D__SYCL_INTERNAL_API -o %t.out
// RUN: %{run-unfiltered-devices} %t.out
//
// hip_nvidia has problems constructing queues due to `No device of requested
// type available`.
// XFAIL: hip_nvidia

//==-------- queue_old_interop.cpp - SYCL queue OpenCL interop test --------==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/DeviceCodeSplit/split-per-kernel.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// RUN: %{build} -Wno-error=unused-command-line-argument -fsycl-device-code-split=per_kernel -o %t.out \
// RUN: -fsycl-dead-args-optimization
// RUN: %{run} %t.out
//
// XFAIL: hip_nvidia

#include <sycl/detail/core.hpp>
#include <sycl/kernel_bundle.hpp>
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/DeviceCodeSplit/split-per-source-main.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// RUN: %{build} -Wno-error=unused-command-line-argument -fsycl-device-code-split=per_source -I %S/Inputs -o %t.out %S/Inputs/split-per-source-second-file.cpp \
// RUN: -fsycl-dead-args-optimization
// RUN: %{run} %t.out
//
// XFAIL: hip_nvidia

#include "Inputs/split-per-source.h"

Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/GroupAlgorithm/root_group.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Fails with opencl non-cpu, enable when fixed.
// XFAIL: (opencl && !cpu && !accelerator)
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14641

// RUN: %{build} -I . -o %t.out %if any-device-is-cuda %{ -Xsycl-target-backend=nvptx64-nvidia-cuda --cuda-gpu-arch=sm_70 %}
// RUN: %{run} %t.out

Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/GroupLocalMemory/group_local_memory.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// RUN: %{build} -Wno-error=deprecated-declarations -o %t.out
// RUN: %{run} %t.out
//
// XFAIL: hip_nvidia

#include <sycl/detail/core.hpp>

Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/GroupLocalMemory/no_early_opt.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// RUN: %{build} -Wno-error=deprecated-declarations -fno-sycl-early-optimizations -o %t.out
// RUN: %{run} %t.out
//
// XFAIL: hip_nvidia

// The test checks that multiple calls to the same template instantiation of a
// group local memory function result in separate allocations, even with device
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// TODO: Passing/returning structures via invoke_simd() API is not implemented
// in GPU driver yet. Enable the test when GPU RT supports it.
// XFAIL: gpu && run-mode
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14543
//
// RUN: %{build} -DIMPL_SUBGROUP -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr -o %t.out
// RUN: env IGC_VCSaveStackCallLinkage=1 IGC_VCDirectCallsOnly=1 %{run} %t.out
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/InvokeSimd/Feature/invoke_simd_struct.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// TODO: Passing/returning structures via invoke_simd() API is not implemented
// in GPU driver yet. Enable the test when GPU RT supports it.
// XFAIL: gpu, run-mode
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14543
//
// RUN: %{build} -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr -o %t.out
// RUN: env IGC_VCSaveStackCallLinkage=1 IGC_VCDirectCallsOnly=1 %{run} %t.out
Expand Down
15 changes: 0 additions & 15 deletions sycl/test-e2e/InvokeSimd/Spec/ImplicitSubgroup/tuple.cpp

This file was deleted.

15 changes: 0 additions & 15 deletions sycl/test-e2e/InvokeSimd/Spec/ImplicitSubgroup/tuple_return.cpp

This file was deleted.

15 changes: 0 additions & 15 deletions sycl/test-e2e/InvokeSimd/Spec/ImplicitSubgroup/tuple_vadd.cpp

This file was deleted.

147 changes: 0 additions & 147 deletions sycl/test-e2e/InvokeSimd/Spec/tuple.cpp

This file was deleted.

Loading

0 comments on commit b0000e0

Please sign in to comment.