Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add github_user_ssh_signing_key #2366

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

simonostendorf
Copy link

@simonostendorf simonostendorf commented Aug 26, 2024

Resolves #2365

Resolves #1917


Before the change?

  • managing ssh signing keys was not possible

After the change?

  • managing ssh signing keys is possible with github_user_ssh_signing_key resource
  • the resource is equal to the existing github_user_ssh_key resource that manages ssh auth keys

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@kfcampbell
Copy link
Member

@simonostendorf can you please link to the new doc you created in the github.erb file so it's discoverable?

@simonostendorf
Copy link
Author

@simonostendorf can you please link to the new doc you created in the github.erb file so it's discoverable?

@kfcampbell sorry forgot that. I added it now.

@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from 875d76f to 1dde54f Compare September 15, 2024 08:06
@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from f5d9e6d to 3860cf3 Compare September 22, 2024 16:20
@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from 065e10e to efcc88e Compare September 28, 2024 15:22
@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from 009fd4b to 4713629 Compare October 10, 2024 11:42
@quotidian-ennui
Copy link

#1917 should perhaps be formally linked to this PR as well since it appears equivalent to #2365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add difference of auth and signing keys to github_user_ssh_key [FEAT]: Support SSH signing keys
3 participants