Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable custom protection rule on GH environment #2352

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ishan11
Copy link

@ishan11 ishan11 commented Aug 18, 2024

Resolves #2225


Before the change?

  • No resource to enable custom protection rule on environment

After the change?

  • New resource introduced that will allow for enabling custom protection rule on environment via terraform

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Testing Results

image


@ishan11 ishan11 changed the title Gh env custom protection rule feat: Enable custom protection rule on GH environment Aug 18, 2024
@ishan11
Copy link
Author

ishan11 commented Aug 21, 2024

@kfcampbell Could you please review this PR, getting it merged and released would be really helpful for my team?

@ishan11
Copy link
Author

ishan11 commented Sep 29, 2024

@kfcampbell Can you take a look at this? would really help simplify my current workflow

@benjamin-scc
Copy link

@ishan11 As a workaround until officially supported by the provider, are you using null_resource with local-exec to call the GitHub API directly via Terraform?

@ishan11
Copy link
Author

ishan11 commented Nov 9, 2024

We ended up using a Rest API TF Provider but u think using a null resource with local exec would be fine as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add support for deployment protection rules
3 participants