Skip to content

Commit

Permalink
Changes for v2.0.1 (#15)
Browse files Browse the repository at this point in the history
* Fix doxygen.conf to reflect Sage Intacct #9
* DepartmentUpdate should not be writing Title if null #10
* Clean up comment in ApAdjustmentDelete
* Remove bad copied fields from ChargeCardTransactionUpdate
* ApPaymentRequestItem should implement IXmlObject #11
* Update version for 2.0.1
  • Loading branch information
jimmymcpeter authored Jan 26, 2018
1 parent 81f4ca9 commit 5298978
Show file tree
Hide file tree
Showing 10 changed files with 9 additions and 15 deletions.
2 changes: 0 additions & 2 deletions Intacct.SDK.Tests/Functions/Company/DepartmentUpdateTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,13 @@ public void GetXmlTest()
<update>
<DEPARTMENT>
<DEPARTMENTID>D1234</DEPARTMENTID>
<TITLE>hello world</TITLE>
</DEPARTMENT>
</update>
</function>";

DepartmentUpdate record = new DepartmentUpdate("unittest")
{
DepartmentId = "D1234",
DepartmentName = "hello world"
};
this.CompareXml(expected, record);
}
Expand Down
2 changes: 1 addition & 1 deletion Intacct.SDK.Tests/SessionProviderTest.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.IO;
using System.Net;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public override void WriteXml(ref IaXmlWriter xml)

xml.WriteAttribute("key", RecordNo);

xml.WriteEndElement(); //delete_apaccountlabel
xml.WriteEndElement(); //delete_apadjustment

xml.WriteEndElement(); //function
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

namespace Intacct.SDK.Functions.AccountsPayable
{
public class ApPaymentRequestItem
public class ApPaymentRequestItem : IXmlObject
{

public int? ApplyToRecordId;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ namespace Intacct.SDK.Functions.CashManagement
public class ChargeCardTransactionUpdate : AbstractChargeCardTransaction
{

public DateTime ReverseDate;

public string Memo;

public ChargeCardTransactionUpdate(string controlId = null) : base(controlId)
{
}
Expand Down
4 changes: 2 additions & 2 deletions Intacct.SDK/Functions/Company/DepartmentUpdate.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ public override void WriteXml(ref IaXmlWriter xml)
xml.WriteStartElement("DEPARTMENT");

xml.WriteElement("DEPARTMENTID", DepartmentId, true);
xml.WriteElement("TITLE", DepartmentName, true);


xml.WriteElement("TITLE", DepartmentName);
xml.WriteElement("PARENTID", ParentDepartmentId);
xml.WriteElement("SUPERVISORID", ManagerEmployeeId);

Expand Down
2 changes: 1 addition & 1 deletion Intacct.SDK/Intacct.SDK.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<TargetFramework>netstandard1.6</TargetFramework>
<PackageId>Intacct.SDK</PackageId>
<PackageVersion>2.0.0</PackageVersion>
<PackageVersion>2.0.1</PackageVersion>
<Authors>intacct</Authors>
<AssemblyTitle>Sage Intacct SDK</AssemblyTitle>
<Description>Sage Intacct SDK for .NET</Description>
Expand Down
2 changes: 1 addition & 1 deletion Intacct.SDK/SessionProvider.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*
/*
* Copyright 2018 Sage Intacct, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"). You may not
Expand Down
2 changes: 1 addition & 1 deletion Intacct.SDK/Xml/RequestHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace Intacct.SDK.Xml
{
public class RequestHandler
{
public const string Version = "2.0";
public const string Version = "2.0.1";

public ClientConfig ClientConfig;

Expand Down
2 changes: 1 addition & 1 deletion docs/doxygen.conf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Project related configuration options
#---------------------------------------------------------------------------
DOXYFILE_ENCODING = UTF-8
PROJECT_NAME = "Intacct SDK for .NET"
PROJECT_NAME = "Sage Intacct SDK for .NET"
PROJECT_NUMBER =
PROJECT_BRIEF =
PROJECT_LOGO =
Expand Down

0 comments on commit 5298978

Please sign in to comment.