-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add GitHub Action and Markdown linter #17
Conversation
521a210
to
1ccebb1
Compare
@mairin @connor-leech @jjasghar @sstano Hey y'all, I've added this GHA linter and fixed some linting issues but it did require changing the existing |
Will hold off on merging until I know I won't break the website deploys 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I will check with @mscherer to plan to test it.
I am very much in favour of this, but given that we already struggle a bit with the regular linter, I would prefer if that's applied after Summit. (and the current PR can't be merged as we changed the SECURITY.md file) |
@mscherer we can definitely hold this, no rush to do this before Summit |
@mscherer can we revisit this now that Summit is over? |
Signed-off-by: Nathan Weinberg <[email protected]>
Signed-off-by: Nathan Weinberg <[email protected]>
Rebased but I still need to harden these actions per @bjhargrave's examples in other repos |
Signed-off-by: Nathan Weinberg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to include .github/dependabot.yml
to manage the actions.
See https://github.com/instructlab/.github/blob/main/.github/dependabot.yml
You should add a section to the dependabot config to handle the JS/yarn dependencies.
Signed-off-by: Nathan Weinberg <[email protected]>
Signed-off-by: Nathan Weinberg <[email protected]>
This is a meta-linter of sorts that lints GitHub Actions themselves
Should be useful when we introduce more CI to this repository