Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add GitHub Action and Markdown linter #17

Merged
merged 5 commits into from
May 16, 2024

Conversation

nathan-weinberg
Copy link
Member

This is a meta-linter of sorts that lints GitHub Actions themselves

Should be useful when we introduce more CI to this repository

@nathan-weinberg nathan-weinberg force-pushed the ci branch 3 times, most recently from 521a210 to 1ccebb1 Compare April 25, 2024 20:57
@nathan-weinberg
Copy link
Member Author

@mairin @connor-leech @jjasghar @sstano Hey y'all, I've added this GHA linter and fixed some linting issues but it did require changing the existing nextjs action - is there a way I can test if I broke any functionality or not? Last thing I want to do is set y'all back with this

@nathan-weinberg
Copy link
Member Author

Will hold off on merging until I know I won't break the website deploys 😄

Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I will check with @mscherer to plan to test it.

@nathan-weinberg nathan-weinberg changed the title ci: add GitHub Action linter ci: add GitHub Action and Markdown linter Apr 26, 2024
@mscherer
Copy link
Contributor

mscherer commented May 2, 2024

I am very much in favour of this, but given that we already struggle a bit with the regular linter, I would prefer if that's applied after Summit. (and the current PR can't be merged as we changed the SECURITY.md file)

@nathan-weinberg
Copy link
Member Author

@mscherer we can definitely hold this, no rush to do this before Summit

@nathan-weinberg
Copy link
Member Author

@mscherer can we revisit this now that Summit is over?

Signed-off-by: Nathan Weinberg <[email protected]>
@nathan-weinberg
Copy link
Member Author

Rebased but I still need to harden these actions per @bjhargrave's examples in other repos

Signed-off-by: Nathan Weinberg <[email protected]>
Copy link

@bjhargrave bjhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to include .github/dependabot.yml to manage the actions.

See https://github.com/instructlab/.github/blob/main/.github/dependabot.yml

You should add a section to the dependabot config to handle the JS/yarn dependencies.

Makefile Outdated Show resolved Hide resolved
Signed-off-by: Nathan Weinberg <[email protected]>
@nathan-weinberg nathan-weinberg merged commit 485b769 into instructlab:main May 16, 2024
6 checks passed
@nathan-weinberg nathan-weinberg deleted the ci branch May 16, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants