Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement parallel matrices #388

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gregory-Pereira
Copy link
Collaborator

Redo of #363, which got reverted in #387 .
The accessing separate env and secrets doesnt work for login, this needs to be refactored. Keeping as draft for now

@Gregory-Pereira Gregory-Pereira force-pushed the streamline-release-images-workflow-v2 branch from 91e8575 to 6a64674 Compare December 16, 2024 17:29
@Gregory-Pereira Gregory-Pereira marked this pull request as ready for review December 16, 2024 17:32
@Gregory-Pereira Gregory-Pereira changed the title WIP: re-implement parallel matrices Re-implement parallel matrices Dec 16, 2024
@Gregory-Pereira Gregory-Pereira force-pushed the streamline-release-images-workflow-v2 branch from 6a64674 to 804fdcc Compare December 16, 2024 17:40
@Gregory-Pereira
Copy link
Collaborator Author

Changes:

  • According to the docs, attestation and SBOM support is build directly into the docker/build-push-action for any version later than v4, thus we can remove our attestation steps.
  • Matrices implementation ONLY for images, and not registry auth. Each image will be built and pushed to both registries at once which should be optimized due to the caching

I want to keep the feature changes small to minimize disruptions. However when we have time I want to next investigate removing the caching step. This is because we are caching Docker layers using actions/cache@v4, but docker/build-push-action@v6 supports its own caching mechanism (type=gha). While this used to make sense for separate build steps, now that we have aggregated them, technically it shouldn't be needed.

@Gregory-Pereira Gregory-Pereira added the blocked Blocked by another task or pull request label Dec 16, 2024
@Gregory-Pereira Gregory-Pereira marked this pull request as draft December 16, 2024 20:18
@Gregory-Pereira
Copy link
Collaborator Author

/HOLD

Waiting for the Jan 9th release so we dont ruin our workflows. Can pick this up again then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by another task or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant