Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the UI login page #115

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

vishnoianil
Copy link
Member

@vishnoianil vishnoianil commented Aug 14, 2024

Production login page entire redesigned. It only provides the github login option.

To use the dev login, set the IL_UI_DEPLOYMENT env variable to "dev" in .env file. This will display the old login page with user name/password and github login as well.

Fixes #76

@vishnoianil vishnoianil requested a review from nerdalert August 14, 2024 08:34
@vishnoianil
Copy link
Member Author

Screenshot 2024-08-14 at 1 35 22 AM

Above snapshot shows how UI login page will look like in the production deployment.

@vishnoianil
Copy link
Member Author

@Misjohns Please review the above snapshot and let me know if you have any feedback.

@Misjohns
Copy link
Collaborator

@vishnoianil On the original log in there are 3 links: Terms of Use, Help, and Privacy Policy. All 3 link to InstructLab.ai where I do not see any mention of these. I think we should either:

  1. Link to the InstructLab GitHub project instead, linking to the ReadMe.md page and add that content there or
  2. Remove the links we display on the log in and just display "By signing in, you agree to our terms of service and privacy policy." as plain text.

Also, we should make the link color white with underlines since the contrast with the blue links on the purple is horrible.

@vishnoianil vishnoianil force-pushed the login-redesign branch 2 times, most recently from 963bad4 to f7c6117 Compare August 15, 2024 08:14
Production login page entire redesigned. It only
provides the github login option.

To use the dev login, set the IL_UI_DEPLOYMENT env
variable in .env to dev. This will display the old
login page with user name/password and github login
as well.

Signed-off-by: Anil Vishnoi <[email protected]>
Copy link
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 lgtm

@nerdalert nerdalert merged commit 642e0cf into instructlab:main Aug 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the github login UI
3 participants