Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing trailing slash for url #112

Merged

Conversation

MuhammadKurdi-CS
Copy link
Collaborator

No description provided.

Signed-off-by: Muhammad Mohammadi <[email protected]>
Copy link
Member

@aevo98765 aevo98765 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like we discussed before @MuhammadKurdi-CS this does resolve the issue raised in #84. There is further validation work that can be enforced on these input fields and we should raise future issues around this.

@aevo98765 aevo98765 merged commit 8879f24 into instructlab:main Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants