Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knowledge: characteristics and habitat information of squid #1362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Knowledge: characteristics and habitat information of squid #1362

wants to merge 1 commit into from

Conversation

chunho6905
Copy link

Comprehensive knowledge about West Sea squid including their habitat preferences, seasonal patterns, living depths, and feeding habits. This information helps anglers understand squid behavior for more successful fishing.

@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged knowledge (Auto labeled) labels Dec 6, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

@chunho6905 chunho6905 force-pushed the knowledge-contribution-1733457895573 branch 3 times, most recently from 4fbe395 to 8c578c2 Compare December 10, 2024 14:57
@chunho6905 chunho6905 closed this Dec 10, 2024
@chunho6905 chunho6905 deleted the knowledge-contribution-1733457895573 branch December 10, 2024 15:04
@chunho6905 chunho6905 restored the knowledge-contribution-1733457895573 branch December 10, 2024 15:06
@chunho6905 chunho6905 deleted the knowledge-contribution-1733457895573 branch December 10, 2024 15:13
@chunho6905 chunho6905 restored the knowledge-contribution-1733457895573 branch December 10, 2024 15:13
@chunho6905 chunho6905 reopened this Dec 10, 2024
@chunho6905 chunho6905 force-pushed the knowledge-contribution-1733457895573 branch 2 times, most recently from 0d38831 to 1eb84fd Compare December 10, 2024 15:40
@chunho6905
Copy link
Author

The sources are clearly stated and there don't seem to be any errors. I would be really grateful if you could tell me what else needs to be added for approval.

@jjasghar
Copy link
Member

Please fix the DCO. Then, I will run the next level of automation.

@jjasghar jjasghar added triage-requested-changes skill has been reviewed; changes requested from contributor and removed triage-needed (Auto labeled) skill is ready to be triaged labels Dec 10, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

@chunho6905 chunho6905 force-pushed the knowledge-contribution-1733457895573 branch from 1eb84fd to a6fdce7 Compare December 11, 2024 02:01
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label Dec 11, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

@chunho6905
Copy link
Author

chunho6905 commented Dec 11, 2024 •
edited
Loading

Signed-off-by: CHUNHO KIM [email protected]
As you can see, I added the DCO. But why do DCO errors keep occurring?

@chunho6905 chunho6905 force-pushed the knowledge-contribution-1733457895573 branch from a6fdce7 to 3525434 Compare December 11, 2024 02:10
@jjasghar jjasghar force-pushed the knowledge-contribution-1733457895573 branch from 3525434 to b1f7c79 Compare December 19, 2024 18:26
@chunho6905 @jjasghar
Added squid characteristics and habitat
3d4ce7a 
Added per the wikipedia article.

Signed-off-by: CHUNHO KIM <[email protected]>
Signed-off-by: JJ Asghar <[email protected]>
@jjasghar jjasghar force-pushed the knowledge-contribution-1733457895573 branch from b1f7c79 to 3d4ce7a Compare December 19, 2024 18:27
@jjasghar jjasghar removed the triage-needed (Auto labeled) skill is ready to be triaged label Dec 19, 2024
jjasghar
jjasghar requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the contexts to exactly match the source documentation, and match the source documentation to the attribution.txt

knowledge/knowledge/fishing/west-coast/squid/characteristics/qna.yaml
repo: https://github.com/chunho6905/taxonomy-knowledge-docs
commit: a9e1c527dcd90d36a659632e6bd0554d019944a6
patterns:
- West Sea Squid Fishing Guide-20241206T040224018.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document needs to reflect https://en.wikipedia.org/wiki/Octopus from your Attribution.txt file at the beginning.
Not to mention the file is not the complete matching of the context you have submitted here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

This pull request has been automatically marked as stale because it has not had activity within 15 days. It will be automatically closed if no further activity occurs within the next 31 days.

@github-actions github-actions bot added the stale stale-bot has marked you as stale label Jan 4, 2025
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjasghar jjasghar jjasghar requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
knowledge (Auto labeled) stale stale-bot has marked you as stale triage-requested-changes skill has been reviewed; changes requested from contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chunho6905 @jjasghar