Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knowledge: IBM Granite Knowledge #1356

Closed

Conversation

mormdan
Copy link

@mormdan mormdan commented Dec 1, 2024

Knowledge contribution about the IBM Granite model.

Signed-off-by: Mohamed Ramadan <[email protected]>
@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged knowledge (Auto labeled) labels Dec 1, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the DCO :)

@jjasghar
Copy link
Member

jjasghar commented Dec 1, 2024

@mcorbin-ibm This seems like at least a great start to IBM Granite, but the location will probably need to be somewhere else. We should discuss this in a triage meeting sooner then later. (this maybe a great example submission in the future too)

@jjasghar jjasghar added triage-requested-changes skill has been reviewed; changes requested from contributor and removed triage-needed (Auto labeled) skill is ready to be triaged labels Dec 1, 2024
@mcorbin-ibm
Copy link
Contributor

@jjasghar This PR was likely opened from them completing this InstructLab UI tutorial:
https://developer.ibm.com/tutorials/awb-contributing-llm-granite-instructlab-ui/

@jjasghar
Copy link
Member

Thank you for this submission. It's great to see you learning from @ahmed-azraq's blog post! Unfortunately, we can't accept it because it seems we have had multiple submissions on the exact same topic of IBM Granite.

Now that you know how to submit new knowledge,if you find some time to make another submission, we'd love to see if it improves the model and, ideally, merge it into our public taxonomy!

Again, thank you for this, and looking forward to you helping out the InstructLab community.

@jjasghar jjasghar closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
knowledge (Auto labeled) triage-requested-changes skill has been reviewed; changes requested from contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants