Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

details about city district #1300

Closed
wants to merge 2 commits into from
Closed

Conversation

pepadelic
Copy link

Describe the contribution to the taxonomy

  • Incorrect answer identified regarding topic related to geography and other details related to Brno city and it's district Bystrc (considered as good fix for first contribution to taxonomy project and to get familiar with the workflow)
  • knowledge qna.yaml and attribution.txt created as per guidelines, generated synthetic data, trained the model and verified that new model provides correct information

Input given at the prompt

in what city is bystrc district? 

Response from the original model

| The Bystřice District is located in the region of Central Bohemia, Czech Republic. This district is	│
│ part of the larger Bohemian Plateau, which stretches from Prague to the German border. Bystřice    	│
│ District is known for its picturesque landscapes, including hills, forests, and rivers, as well as 	│
│ historic towns and villages with medieval architecture. Some notable places in the district include	│
│ Bystřice pod Hostýnem, a town famous        

Response from the fine-tuned model

| Bystrc District is located in the city of Brno, Czech Republic. Brno is the second largest city in 	│
│ Czechia and has a population of about 380,000 people. It's known for its rich cultural life and as one │
│ of the most important scientific centers in the country.                                           	│
│                                                                                                    	│
│ The Bystrc district itself was established back in 1925 and covers an area of approximately 6.4 km2	│
│ (or 2.47 sq mi). The district is primarily residential, with some industrial areas as well. It's   	│
│ located near the northwestern part of Brno and can be accessed easily through public transportation or │
│ by car.                                                  	

Contribution checklist

  • [ x] The contribution was tested with ilab generate
  • [ x] No errors or warnings were produced by ilab generate
  • All commits are signed off (DCO)
  • [x ] The qna.yaml file contains at least 5 seed_examples
  • [x ] The qna.yaml file was linted and prettified (yaml-validator can do both)
  • [ x] An attribution.txt file in the same folder as the qna.yaml file
  • [ x] Content does not include PII or otherwise sensitive or confidential information
  • [x ] Content does not include anything documented in the project's Avoid these Topics guidelines

Signed-off-by: pepadelic <[email protected]>
Signed-off-by: pepadelic <[email protected]>
@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged knowledge (Auto labeled) labels Sep 22, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

@pepadelic
Copy link
Author

not necessarily clear whether the path to knowledge files within taxonomy tree is selected by contributor or maintainer (my understanding is that maintainers take care of creating right path as per DDC classifications at the moment)

@jjasghar
Copy link
Member

@instructlab-bot precheck

Copy link

Beep, boop 🤖, Here are the precheck results for your PR using the model granite-7b-lab!

Results can be found here.

Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source information needs to be English, translations are not accepted.

@@ -0,0 +1,5 @@
Title of work: Brno-Bystrc
Link to work: https://cs.wikipedia.org/wiki/Brno-Bystrc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry but we can not accept non-english references.

changing this to en changes the page, and doesn't have the data you have below.

@jjasghar jjasghar added triage-rejected PR fails to meet criteria and removed triage-needed (Auto labeled) skill is ready to be triaged labels Sep 24, 2024
@jjasghar
Copy link
Member

Closing per Triage discussion.

@jjasghar jjasghar closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
knowledge (Auto labeled) triage-rejected PR fails to meet criteria
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants