Deleted pre-commit yaml #1292
Merged
Deleted pre-commit yaml #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use this in our taxonomy repo, and it seems it's only for very specific usecases. Signed-off-by: JJ Asghar <[email protected]>
|
With all respect that is not going to help you maintain submission quality. Without pre-commit your going to have to deal with people making lot of easily avoidable mistakes. Instead of deleting it, you should double down and make using pre-commit part of your contribution guidlines. |
|
We discussed this during our triage call, and came to the conclusion that the linter should be doing this work. The people who will be submitting to the upstream taxonomy won't know what a "pre-hook" is in general. We are hoping/expecting more of our community to be non-developers and want to remove confusion and stream line as best as possible. |
bjhargrave
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use this in our taxonomy repo, and it seems it's only for very specific usecases.