Use instructlab-schema package to parse qna.yaml files #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@russellb Here is a draft PR using the taxonomy parsing code in instructlab/schema#33. Would be great to get your feedback on the instructlab-schema code before I merge. |
27 tasks
bjhargrave
force-pushed
the
schema-taxonomy-parsing
branch
from
e475b9d to
9a1a748
Compare
|
@hickeyma This PR is now ready for review. |
bjhargrave
changed the title
bjhargrave
force-pushed
the
schema-taxonomy-parsing
branch
from
9a1a748 to
5c23285
Compare
mergify
bot
added
documentation
bjhargrave
force-pushed
the
schema-taxonomy-parsing
branch
from
5c23285 to
4d4aacb
Compare
bjhargrave
force-pushed
the
schema-taxonomy-parsing
branch
from
4d4aacb to
8476da7
Compare
nathan-weinberg
approved these changes
Aug 20, 2024
markstur
approved these changes
Aug 20, 2024
|
@Mergifyio rebase |
The ci build does not test python 3.9 and instructlab now requires 3.10 as the base version of python. Signed-off-by: BJ Hargrave <[email protected]>
Signed-off-by: BJ Hargrave <[email protected]>
We remove code duplicated with instructlab to use the shared code from instructlab-schema package. A test case is also fixed which incorrectly passed a config string when the name of a config file is the proper argument. Signed-off-by: BJ Hargrave <[email protected]>
✅ Branch has been successfully rebased |
hickeyma
force-pushed
the
schema-taxonomy-parsing
branch
from
8476da7 to
0b2f5a4
Compare
class for the YAML rule. This is to adhere to the centralized schema validation and parsing in https://github.com/instructlab/schema. Signed-off-by: Martin Hickey <[email protected]>
|
CLI now using schema parsing and validation. Ref: instructlab/instructlab#1962. Reviewed and ready to merge. |
jwm4
pushed a commit
to jwm4/sdg
that referenced
this pull request
Dec 13, 2024
…actions/step-security/harden-runner-2.8.0 build(deps): bump step-security/harden-runner from 2.7.1 to 2.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove code duplicated with instructlab to use the shared code from instructlab-schema package.
See instructlab/schema#33