Refactor Document Chunker to always use docling #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Khaled Sulayman <[email protected]>
Signed-off-by: Khaled Sulayman <[email protected]>
RobotSail
reviewed
Dec 6, 2024
|
|
||
|
|
||
|
|
||
| # class DocumentChunker: |
There was a problem hiding this comment.
Should we keep this commented out or would it make more sense to delete it? It'll always be in git history if we need to find it again
There was a problem hiding this comment.
Ah sorry, forgot to remove these
Might set this PR to draft until I'm able to get tests to pass and then do one final linting cleanup
RobotSail
reviewed
Dec 6, 2024
| self.server_ctx_size = server_ctx_size | ||
| self.chunk_word_count = chunk_word_count | ||
| self.output_dir = output_dir | ||
| if len(document_paths) == 0: |
There was a problem hiding this comment.
Just an FYI, in Python you can do if not document_path and it will perform both if document_path is None or len(document_paths) == 0
Signed-off-by: Khaled Sulayman <[email protected]>
Signed-off-by: Khaled Sulayman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old DocumentChunker was a factory class that called the text-splitter on markdowns and docling on PDFs. In reality, we want to call docling and then use the text-splitter on all document types. This change refactors the DocumentChunker class to always call docling (as long as the provided documents are supported filetypes).
Resolves: #334