Prefer tesserocr over easyocr, if available (backport #369) #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
When setting up our ingestion pipeline, explicitly check if tesserocr is available and Docling can load it. If so, prefer that. Otherwise, attempt the same for EasyOCR. If neither can load, log an error and disable optical character recognition. Fixes #352 Signed-off-by: Ben Browning <[email protected]> (cherry picked from commit ba00454)
This borrows and adapts the `leanimports.py` script and test from the InstructLab CLI repository to ensure within SDG we're not prematurely loading the entirety of Torch into memory. The CLI repo noticed we were doing this, and since this PR would actually have exacerbated this by attempting to load the tesseract and easyocr modules even earlier, this felt like the right time to address this. The overall imports are all the same, but now we only import specific docling pieces as needed when we're actually going to run chunking vs triggering the whole PyTorch import chain as soon as someone imports SDG. Signed-off-by: Ben Browning <[email protected]> (cherry picked from commit 791fc7f)
nathan-weinberg
approved these changes
Nov 15, 2024
mergify
bot
added
testing
khaledsulayman
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up our ingestion pipeline, explicitly check if tesserocr is available and Docling can load it. If so, prefer that. Otherwise, attempt the same for EasyOCR. If neither can load, log an error and disable optical character recognition.
Fixes #352
This is an automatic backport of pull request #369 done by Mergify.