Add simple and full knowledge pipeline functional tests #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
testing
|
This pull request has merge conflicts that must be resolved before it can be |
This is a port of the old `scripts/test_knowledge.py` into functional tests that we can run with CI. These tests take longer, so are marked as `slow` in pytest. Signed-off-by: Ben Browning <[email protected]>
bbrowning
force-pushed
the
port_old_tests
branch
from
745ad35 to
6f377bc
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the old
test_knowledge.pymanual test script and ports it into simple and full knowledge pipeline functional tests. Note that this is a draft because these tests take a while (over 10 minutes on my machine), so likely need to consider GPU-accelerating them and moving them over to the e2e runners or new runners. All that TBD, but checkpointing work here to park it for a bit while working on something else.