Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use org variable for AWS EC2 AMI in E2E CI jobs #322

Merged
merged 1 commit into from
Oct 25, 2024
Merged

ci: use org variable for AWS EC2 AMI in E2E CI jobs #322

merged 1 commit into from
Oct 25, 2024

Conversation

nathan-weinberg
Copy link
Member

This will allow us to do the following:

  1. Keep the AMI consistent across all of InstructLab
  2. Allow for updating the AMI without having to make a code change

@nathan-weinberg nathan-weinberg requested review from n1hility, danmcp and a team October 24, 2024 16:56
@mergify mergify bot added the CI/CD Affects CI/CD configuration label Oct 24, 2024
@mergify mergify bot added the one-approval label Oct 24, 2024
@mergify mergify bot removed the one-approval label Oct 24, 2024
@nathan-weinberg nathan-weinberg removed the request for review from n1hility October 25, 2024 02:46
@mergify mergify bot merged commit caa6e98 into instructlab:main Oct 25, 2024
14 checks passed
@nathan-weinberg nathan-weinberg deleted the ami branch October 25, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimaredia alimaredia alimaredia approved these changes

@danmcp danmcp danmcp approved these changes

Assignees
No one assigned
Labels
CI/CD Affects CI/CD configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathan-weinberg @danmcp @alimaredia