build(deps): update datasets requirement from <3.0.0,>=2.18.0 to >=2.18.0,<4.0.0 #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [datasets](https://github.com/huggingface/datasets) to permit the latest version. - [Release notes](https://github.com/huggingface/datasets/releases) - [Commits](huggingface/datasets@2.18.0...3.0.0) --- updated-dependencies: - dependency-name: datasets dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
@instructlab/sdg-maintainers do we want this bump? |
|
Hmm - I don't know if we want to automatically pull in 3.0.0 without perhaps some explicit testing, given that it's a new major version. I'm inclined to not merge this change in requirement until or unless someone specifically wants to upgrade to datasets 3.x from 2.x? Maybe someone more knowledgeable about exactly how we use datasets and whether anything in 3.0 touches any of the parts we use chimes in? |
|
-1 (was plus one for what bbrowning said) 3.0 has breaking changes. dependabot is being a bit aggressive here unless dependabot did the testing. |
|
@dependabot ignore this major version |
|
OK, I won't notify you about version 3.x.x again, unless you re-open this PR. |
dependabot
bot
deleted the
dependabot/pip/datasets-gte-2.18.0-and-lt-4.0.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on datasets to permit the latest version.
Release notes
Sourced from datasets's releases.
Commits
3505ed9Release: 3.0.0 (#7145)ca58154fix streaming from arrow files (#7083)be5cff0Test get_dataset_config_info with non-existing/gated/private dataset (#7124)e4c87a6Disable implicit token in CI (#7126)880a52cFix wrong SHA in CI tests of HubDatasetModuleFactoryWithParquetExport (#7125)88f646cRename LargeList.dtype to LargeList.feature (#7106)3813ce8Fix typed examples iterable state dict (#7121)cedffa5don't mention the script if trust_remote_code=False (#7120)2878019Usehuggingface_hubcache (#7105)70bac27Install transformers with numpy-2 CI (#7119)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)