Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add AWS tag to show github PR number for all jobs #264

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

nathan-weinberg
Copy link
Member

@nathan-weinberg nathan-weinberg commented Sep 3, 2024

right now we can see what type of runner and which repository an AWS runner is associated with, but not which PR number triggered it

see instructlab/instructlab#2183 for reference

@nathan-weinberg nathan-weinberg requested a review from a team September 3, 2024 15:10
Copy link
Member

@danmcp danmcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we determined from here: instructlab/instructlab#2183 this probably isn't the best approach.

@nathan-weinberg
Copy link
Member Author

I think we determined from here: instructlab/instructlab#2183 this probably isn't the best approach.

Should we try github.event.pull_request.number? cc @russellb

@danmcp
Copy link
Member

danmcp commented Sep 3, 2024

I think we determined from here: instructlab/instructlab#2183 this probably isn't the best approach.

Should we try github.event.pull_request.number? cc @russellb

It looks like github.event.number should work

@nathan-weinberg nathan-weinberg changed the title ci: add AWS tag to show github ref for all jobs ci: add AWS tag to show github PR number for all jobs Sep 3, 2024
right now we can see what type of runner and which
repository an AWS runner is associated with, but not
which PR number triggered it

Signed-off-by: Nathan Weinberg <[email protected]>
@nathan-weinberg nathan-weinberg merged commit 47cabbb into instructlab:main Sep 3, 2024
11 checks passed
@nathan-weinberg nathan-weinberg deleted the aws-metadata branch September 3, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants