Skip to content

Commit

Permalink
Merge pull request #396 from makelinux/unused
Browse files Browse the repository at this point in the history
refactor: remove unused generate_data arguments
  • Loading branch information
mergify[bot] authored Nov 18, 2024
2 parents 09cdd0a + 7cbe6dd commit 8bb8e3b
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions src/instructlab/sdg/generate_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def _mixer_init(

# This is part of the public API, and used by instructlab.
# TODO - parameter removal needs to be done in sync with a CLI change.
# to be removed: logger, prompt_file_path, rouge_threshold, tls_*
# to be removed: logger
def generate_data(
client: openai.OpenAI,
logger: logging.Logger = logger, # pylint: disable=redefined-outer-name
Expand All @@ -308,10 +308,6 @@ def generate_data(
taxonomy: Optional[str] = None, # TODO rename to taxonomy_path to match config
taxonomy_base: Optional[str] = None,
output_dir: Optional[str] = None,
# TODO - not used and should be removed from the CLI
prompt_file_path: Optional[str] = None, # pylint: disable=unused-argument
# TODO - probably should be removed
rouge_threshold: Optional[float] = None, # pylint: disable=unused-argument
console_output=True,
yaml_rules: Optional[str] = None,
chunk_word_count=None,
Expand Down

0 comments on commit 8bb8e3b

Please sign in to comment.