Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of life changes #8

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Quality of life changes #8

merged 1 commit into from
Dec 18, 2024

Conversation

choener
Copy link
Collaborator

@choener choener commented Dec 17, 2024

  • Stylish Haskell configuration included

  • Disabled nixpkgs-fmt (currently no idea why it breaks in the hook)

  • nonix pre-commit-hook (not tested myself)

* Stylish Haskell configuration included

* Disabled nixpkgs-fmt (currently no idea why it breaks in the hook)

* nonix pre-commit-hook (not tested myself)
@choener choener requested a review from j-mueller December 17, 2024 11:33
@choener
Copy link
Collaborator Author

choener commented Dec 17, 2024

"Backported" from my lobster repo, which I based on the framework here.
I have not tested the nonix stuff, just followed the recommendations there.

@j-mueller
Copy link
Collaborator

j-mueller commented Dec 17, 2024

Looks good but I would expect stylish-haskell to have an effect on the source if it's run correctly as the pre-commit hook

EDIT: Or does it only apply to files that were modified in the commit?

@choener
Copy link
Collaborator Author

choener commented Dec 17, 2024

Looks good but I would expect stylish-haskell to have an effect on the source if it's run correctly as the pre-commit hook

EDIT: Or does it only apply to files that were modified in the commit?

It would apply stylish-haskell to all future commits.
We could also have it disabled -- I would then sync it between nix and non-nix pre-commit configurations.
It would also be possible to choose another formatter, if wanted.

@j-mueller j-mueller merged commit b74c239 into onchain-new Dec 18, 2024
2 checks passed
@j-mueller j-mueller deleted the choener-qol branch December 18, 2024 08:09
j-mueller added a commit that referenced this pull request Dec 18, 2024
* onchain code and export scripts

* onchain code and export scripts

* onchain code and export scripts

* Use library from input-output-hk/catalyst-onchain-libs

* Clean up cabal file, export lists, warnings

* Run export-smart-tokens

* Include nixconfig to to use cache (#6)

* Otherwise ghc and friends will be compiled from source.

* There is a nix failure independent of this change which can be fixed
  by deleting the .pre-commit-config.yaml. This should be checked.

* Remove pre-commit-config yaml (#7)

* This file should be auto-generated and its existence prevents nix
  flake development environments being created.

* Add catalyst-onchain-libs to sha256map; ignore pre-commit-yaml

* fix scripts and finish directory linked list implementation

* fix scripts after rebase

* Quality of life changes (#8)

* Stylish Haskell configuration included

* Disabled nixpkgs-fmt (currently no idea why it breaks in the hook)

* nonix pre-commit-hook (not tested myself)

* Delete txt file, address warnings

* Update dependency

---------

Co-authored-by: Jann Müller <[email protected]>
Co-authored-by: Christian Hoener zu Siederdissen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants