Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-layer image with static assets and binary #50

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

choener
Copy link
Collaborator

@choener choener commented Jan 7, 2025

  • Construct layer with the wst-poc binary

  • Construct second layer with static html assets

  • Currently second layer contains bash, etc for interaction. Can be removed to further shrink the container

Closes #46

@choener choener requested a review from j-mueller January 7, 2025 10:36
@j-mueller j-mueller force-pushed the j-mueller/issue-41/static-files branch from 9f77964 to df86da6 Compare January 7, 2025 10:39
@choener choener force-pushed the 46-package-static-assets-in-container branch from 178d71a to 3cdd007 Compare January 7, 2025 10:44
Base automatically changed from j-mueller/issue-41/static-files to main January 7, 2025 11:44
Copy link
Collaborator

@j-mueller j-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly, thanks!

* Construct layer with the wst-poc binary

* Construct second layer with static html assets

* Currently second layer contains bash, etc for interaction. Can be
  removed to further shrink the container
@choener choener force-pushed the 46-package-static-assets-in-container branch from 3cdd007 to 57635f5 Compare January 7, 2025 12:21
@choener
Copy link
Collaborator Author

choener commented Jan 7, 2025

I have rebased against main.
Once checks are done, I will merge.

@choener choener linked an issue Jan 7, 2025 that may be closed by this pull request
@choener choener merged commit 076b671 into main Jan 7, 2025
4 checks passed
@choener choener deleted the 46-package-static-assets-in-container branch January 7, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package static assets in container
2 participants