Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small patch to correct the parser for static files #48

Merged

Conversation

choener
Copy link
Collaborator

@choener choener commented Jan 6, 2025

I think that (optional) string arguments require the strOption to work correctly.
Otherwise, the program compiles but the parser doesn't do what is expected.
strOption

@choener choener requested a review from j-mueller January 6, 2025 21:50
@j-mueller j-mueller merged commit 60c370c into j-mueller/issue-41/static-files Jan 7, 2025
4 checks passed
@j-mueller j-mueller deleted the choener/static-files-parser branch January 7, 2025 07:08
@j-mueller
Copy link
Collaborator

Thank you!

j-mueller added a commit that referenced this pull request Jan 7, 2025
* API: Serve static files

* Add api/v1 prefix to endpoints

* Small patch to correct the parser for static files (#48)

* Fix build, add test for schema

---------

Co-authored-by: Christian Hoener zu Siederdissen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants