Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Frontend Code #47

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Add Frontend Code #47

merged 5 commits into from
Jan 7, 2025

Conversation

KJES4
Copy link
Collaborator

@KJES4 KJES4 commented Jan 6, 2025

No description provided.

@KJES4 KJES4 requested a review from j-mueller January 6, 2025 15:21
@KJES4 KJES4 self-assigned this Jan 6, 2025
Copy link
Collaborator

@j-mueller j-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@j-mueller j-mueller self-requested a review January 7, 2025 10:04
Copy link
Collaborator

@j-mueller j-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, npm run build fails with

./src/app/styles/themeContext.tsx:26:42
Type error: Argument of type '"light" | "dark"' is not assignable to parameter of type '"light"'.
  Type '"dark"' is not assignable to type '"light"'.

  24 | export const ThemeModeProvider = ({ children }: { children: ReactNode }) => {
  25 |     const [mode, setMode] = useState<'light' | 'dark'>('light');
> 26 |     const theme = useMemo(() => getTheme(mode), [mode]);
     |                                          ^
  27 |   
  28 |     const toggleTheme = () => {
  29 |       setMode((prevMode) => (prevMode === 'light' ? 'dark' : 'light'));

maybe the dark theme related stuff needs to be deleted?

@j-mueller j-mueller mentioned this pull request Jan 7, 2025
@KJES4 KJES4 requested a review from j-mueller January 7, 2025 13:29
Copy link
Collaborator

@j-mueller j-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@j-mueller j-mueller merged commit 32f8c3b into main Jan 7, 2025
4 checks passed
@j-mueller j-mueller deleted the frontend branch January 7, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants