Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script target parameter (debug / production) #37

Merged
merged 11 commits into from
Jan 6, 2025
Merged

Add script target parameter (debug / production) #37

merged 11 commits into from
Jan 6, 2025

Conversation

j-mueller
Copy link
Collaborator

  • Add a script target parameter to all plutarch scripts
  • Add DirectoryScriptRoot and BlacklistTransferLogicScriptRoot types that contain exactly the data we need to compile all of the scripts
  • Parameterise unit tests by script target and add a test group for each of the two targets

@j-mueller j-mueller requested a review from colll78 January 2, 2025 17:04
@j-mueller j-mueller changed the base branch from main to dev-server January 2, 2025 17:05
@j-mueller
Copy link
Collaborator Author

Interesting that including debug symbols causes execution to slow down massively:

image

@j-mueller j-mueller linked an issue Jan 2, 2025 that may be closed by this pull request
Add debug / prod flag to scripts #35
Closed
@j-mueller j-mueller force-pushed the j-mueller/issue-35/debug-mode branch from 1102620 to d7aa324 Compare January 2, 2025 17:12
colll78
colll78 reviewed Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@colll78 colll78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I would just change debug exunits and add the nft check for protocol params utxo and then merge!

src/lib/Wst/Offchain/Query.hs Show resolved Hide resolved
src/test/unit/Wst/Test/UnitTest.hs Outdated Show resolved Hide resolved
Base automatically changed from dev-server to main January 2, 2025 19:16
@j-mueller j-mueller force-pushed the j-mueller/issue-35/debug-mode branch from d7aa324 to f280bf8 Compare January 6, 2025 10:29
@j-mueller j-mueller requested a review from colll78 January 6, 2025 10:47
colll78
colll78 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@colll78 colll78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-mueller j-mueller merged commit 21b4f1c into main Jan 6, 2025
4 checks passed
@j-mueller j-mueller deleted the j-mueller/issue-35/debug-mode branch January 6, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colll78 colll78 colll78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add debug / prod flag to scripts
2 participants
@j-mueller @colll78