Bug Fix PR #33
Merged
Bug Fix PR #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok to me, the tests don't compile though. |
j-mueller
requested changes
Jan 1, 2025
| innerValue | ||
| -- drop the ada entry in the value before traversing the rest of the value entries | ||
| in go # proofList # (ptail # mapInnerList) | ||
| -- pcheckTransferLogic :: Term s (PAsData PCurrencySymbol :--> PBuiltinList (PAsData PTxInInfo) :--> PBuiltinList (PAsData PTokenProof) :--> PBuiltinList (PAsData PByteString) :--> PValue 'Sorted 'Positive :--> PBool) |
|
|
||
| -- in pforgetData insertedKey #== pforgetData outputNodeDatumF.key | ||
| -- #&& pforgetData coveringNext #== pforgetData ptailNextData | ||
| -- in ptraceInfo (pshow $ pmkBuiltinList [pforgetData expectedDirectoryNode]) $ outputNode #== expectedDirectoryNode |
src/lib/Wst/Offchain/Env.hs
Outdated
| @@ -355,14 +355,15 @@ withTransfer dir action = do | |||
| asks (addTransferEnv dir) | |||
| >>= runReaderT action | |||
|
|
|||
| withTransferFor :: MonadReader (CombinedEnv o d t r era) m => C.Hash C.PaymentKey -> ReaderT (CombinedEnv o d Identity r era) m a -> m a | |||
| withTransferFor = withTransfer . mkTransferLogicEnv | |||
| withTransferFor :: MonadReader (CombinedEnv o d t r era) m => C.PaymentCredential -> C.Hash C.PaymentKey -> ReaderT (CombinedEnv o d Identity r era) m a -> m a | |||
There was a problem hiding this comment.
If you change the d parameter to Identity you could get the payment credential from DirectoryEnv.
| ]; | ||
| extra-trusted-public-keys = [ | ||
| "hydra.iohk.io:f/Ea+s+dFdN+3Y/G+FDgSq+a5NEWhJGzdjvKNGv0/EQ=" | ||
| "loony-tools:pr9m4BkM/5/eSTZlkQyRt57Jz7OMBxNSUiMC4FkcNfk=" |
There was a problem hiding this comment.
What do we need this for?
There was a problem hiding this comment.
My nix was refusing to take some stuff from cache without it.
|
Ok some of the tests fail with script errors now, maybe the tx building code needs to be adjusted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few miscellaneous bugs and remove some unnecessary checks.
The bugs mostly had to do with the credential validation within directory node datums.
Importantly, added
programmableLogicBasepayment credential as a parameter to thefreezeAndSeizeTransfercontract because without it we have no way of identifying the actual required witness list and thus the redeemer gets bloated with tons of irrelevant proofs, i.e. a proof thatfreezeAndSeizeTransferitself is not blacklisted.